Re: [PATCH] Bluetooth: remove redundant assignment to variable icid

[Simon Horman]

On Tue, Jan 07, 2020 at 06:00:13PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Variable icid is being rc is assigned with a value that is never
> read. The assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxxx>

> ---
>  net/bluetooth/l2cap_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 1bca608e0170..195459a1e53e 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -5081,7 +5081,6 @@ static inline int l2cap_move_channel_req(struct l2cap_conn *conn,
>  	chan->move_role = L2CAP_MOVE_ROLE_RESPONDER;
>  	l2cap_move_setup(chan);
>  	chan->move_id = req->dest_amp_id;
> -	icid = chan->dcid;
>  
>  	if (req->dest_amp_id == AMP_ID_BREDR) {
>  		/* Moving to BR/EDR */
> -- 
> 2.24.0
>