Re: [resend v1 1/5] block/genhd: Notify udev about capacity change

From: hch@xxxxxx
Date: Wed Jan 08 2020 - 10:04:32 EST


On Tue, Jan 07, 2020 at 10:15:34PM -0500, Martin K. Petersen wrote:
>
> Balbir,
>
> > I did this to avoid having to enforce that set_capacity() implied a
> > notification. Largely to control the impact of the change by default.
>
> What I thought. I'm OK with set_capacity_and_notify(), btw.

To some extent it might make sense to always notify from set_capacity
and have a set_capacity_nonotify if we don't want to notify, as in
general we probably should notify unless we have a good reason not to.