Re: [PATCH] tpm: handle negative priv->response_len in tpm_common_read

From: Jarkko Sakkinen
Date: Wed Jan 08 2020 - 11:05:01 EST


On Wed, 2020-01-08 at 17:58 +0200, Jarkko Sakkinen wrote:
> On Tue, 2020-01-07 at 14:04 -0800, Tadeusz Struk wrote:
> > The priv->responce_length can hold the size of an response or
> > an negative error code, and the tpm_common_read() needs to handle
> > both cases correctly. Changed the type of responce_length to
> > signed and accounted for negative value in tpm_common_read()
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode")
> > Reported-by: Laura Abbott <labbott@xxxxxxxxxx>
> > Signed-off-by: Tadeusz Struk <tadeusz.struk@xxxxxxxxx>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
>
> Adding to the next PR.

Applied but had to fix bunch of typos, missing punctaction and
missing parentheses in the commit message. Even checkpatch.pl
was complaining :-/

Thanks.

/Jarkko