Re: [PATCH v2 04/36] platform/x86: intel_scu_ipc: Remove Lincroft support

[Andy Shevchenko]

On Wed, Jan 08, 2020 at 02:41:29PM +0300, Mika Westerberg wrote:
> Moorestown support was removed years ago with by the commit 1a8359e411eb
> ("x86/mid: Remove Intel Moorestown"). Lincroft is the CPU side chip of
> Moorestown and not supported anymore so remove the code from the driver.
> 

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
>  drivers/platform/x86/intel_scu_ipc.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
> index a8be5bcb9832..6c44fe5e55b5 100644
> --- a/drivers/platform/x86/intel_scu_ipc.c
> +++ b/drivers/platform/x86/intel_scu_ipc.c
> @@ -58,7 +58,6 @@
>  #define IPC_RWBUF_SIZE    20		/* IPC Read buffer Size */
>  #define IPC_IOC	          0x100		/* IPC command register IOC bit */
>  
> -#define PCI_DEVICE_ID_LINCROFT		0x082a
>  #define PCI_DEVICE_ID_PENWELL		0x080e
>  #define PCI_DEVICE_ID_CLOVERVIEW	0x08ea
>  #define PCI_DEVICE_ID_TANGIER		0x11a0
> @@ -70,12 +69,6 @@ struct intel_scu_ipc_pdata_t {
>  	u8 irq_mode;
>  };
>  
> -static const struct intel_scu_ipc_pdata_t intel_scu_ipc_lincroft_pdata = {
> -	.i2c_base = 0xff12b000,
> -	.i2c_len = 0x10,
> -	.irq_mode = 0,
> -};
> -
>  /* Penwell and Cloverview */
>  static const struct intel_scu_ipc_pdata_t intel_scu_ipc_penwell_pdata = {
>  	.i2c_base = 0xff12b000,
> @@ -677,7 +670,6 @@ static int ipc_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  #define SCU_DEVICE(id, pdata)	{PCI_VDEVICE(INTEL, id), (kernel_ulong_t)&pdata}
>  
>  static const struct pci_device_id pci_ids[] = {
> -	SCU_DEVICE(PCI_DEVICE_ID_LINCROFT,	intel_scu_ipc_lincroft_pdata),
>  	SCU_DEVICE(PCI_DEVICE_ID_PENWELL,	intel_scu_ipc_penwell_pdata),
>  	SCU_DEVICE(PCI_DEVICE_ID_CLOVERVIEW,	intel_scu_ipc_penwell_pdata),
>  	SCU_DEVICE(PCI_DEVICE_ID_TANGIER,	intel_scu_ipc_tangier_pdata),
> -- 
> 2.24.1
> 

-- 
With Best Regards,
Andy Shevchenko