Re: [PATCH][resend] ASoC: simple-card: switch to yaml base Documentation

[Kuninori Morimoto]

Hi Rob

Thank you for reviewing

> If you want things reviewed in a timely fashion, use
> get_maintainers.pl and send to the right lists. Otherwise you can just
> hope I happen to see it.

OK, will do from now.

> > +    description: CPU node
> > +    $ref: "#/definitions/dai"
> 
> This is $ref is a description and another $ref. Just do away with 'definitions'.

Sorry, but I don't understand about this.
Do you mean like this ?
	
    description: CPU node
    $ref: "#/dai"

> > patternProperties:
(snip)
> > +  # common properties
> > +  "^simple-audio-card,frame-master$":
> 
> Not a pattern. Put these under 'properties'.

I put it here because it doesn't work
if I put it under "properties".
I'm not 100% understanding, but it seems
using "," at property and "#/definitions/xxx" in the same time
is the reason.

This works for me

	definitions:
	  ...
	  frame-master:
	    description: Indicates dai-link frame master.
	    $ref: /schemas/types.yaml#/definitions/phandle-array
	  ...	  

	patternProperties:
	  ...
	  "^simple-audio-card,frame-master$":
	  $ref: "#/definitions/frame-master"

This works too

	properties:
	  ...
	  simple-audio-card,frame-master:
	    description: Indicates dai-link frame master.
	    $ref: /schemas/types.yaml#/definitions/phandle-array

But, this doesn't work

	properties:
	  ...
	  simple-audio-card,frame-master:
	    $ref: "#/definitions/frame-master"

How to solve it ??

Thank you for your help !!
Best regards
---
Kuninori Morimoto