Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count

[Tobias Schramm]

Am 09.01.20 um 01:15 schrieb Heiko StÃbner:
> Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm:
>> commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes
>> the type of variables used to store the display port data rate and
>> number of lanes to u8. However u8 is not sufficient to store the link
>> data rate of the display port.
>> This commit reverts the type of both the number of lanes and the data
>> rate to unsigned int.
>>
>> Signed-off-by: Tobias Schramm <t.schramm@xxxxxxxxxxx>
>> ---
>>  drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h
>> index 83c4586665b4..806cb0b08982 100644
>> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h
>> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h
>> @@ -94,8 +94,8 @@ struct cdn_dp_device {
>>  	struct video_info video_info;
>>  	struct cdn_dp_port *port[MAX_PHY];
>>  	u8 ports;
>> -	u8 max_lanes;
>> -	u8 max_rate;
>> +	unsigned int max_lanes;
> 
> although I would think u8 should be enough for max_lanes?
> There shouldn't be be more than 255 dp lanes?

True. I'll test and send a v2.

Thanks, Tobias

> 
> Heiko
> 
>> +	unsigned int max_rate;
>>  	u8 lanes;
>>  	int active_port;
>>  
>>
> 
> 
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>