Re: [PATCH 05/16] media: isif: constify copied structure

From: Lad, Prabhakar
Date: Thu Jan 09 2020 - 02:14:01 EST


On Wed, Jan 1, 2020 at 8:20 AM Julia Lawall <Julia.Lawall@xxxxxxxx> wrote:
>
> The isif_config_defaults structure is only copied into another
> structure, so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxxx>
>

Acked-by: Lad Prabhakar <prabhakar.csengg@xxxxxxxxx>

Cheers,
--Prabhakar Lad

> ---
> drivers/media/platform/davinci/isif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/davinci/isif.c b/drivers/media/platform/davinci/isif.c
> index b49378b18e5d..c98edb67cfb2 100644
> --- a/drivers/media/platform/davinci/isif.c
> +++ b/drivers/media/platform/davinci/isif.c
> @@ -29,7 +29,7 @@
> #include "ccdc_hw_device.h"
>
> /* Defaults for module configuration parameters */
> -static struct isif_config_params_raw isif_config_defaults = {
> +static const struct isif_config_params_raw isif_config_defaults = {
> .linearize = {
> .en = 0,
> .corr_shft = ISIF_NO_SHIFT,
>