Re: [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls

[Markus Elfring]

> - fix 'WARNING:' twice in each case.

A duplicate text was removed.


> +@script:python depends on org@
> +p << r.p;
> +ul << r.ul;

I interpret this variable assignment in the way that it will work only
if the corresponding branch of the SmPL disjunction was actually matched
by the referenced SmPL rule.
Thus I suggest now to split the source code search pattern into
four separate rules.


> +warnings = construct_warnings(ul, "div64_ul")

* Can two identifiers be nicer without an âsâ?

* Would it be sufficient to pass a shorter identification
  (without the prefix âdiv64_â)?

Regards,
Markus