Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning

From: Daniel Lezcano
Date: Thu Jan 09 2020 - 07:41:02 EST


On 09/01/2020 13:29, Claudiu.Beznea@xxxxxxxxxxxxx wrote:
>
>
> On 09.01.2020 13:59, Daniel Lezcano wrote:
>> On 06/01/2020 10:58, Claudiu Beznea wrote:
>>> Fix sparse warning.
>>
>> Mind to give the warning?
>
> Sorry, is this one: "warning: Using plain integer as NULL pointer".
>
> Would you like me to send v2 updating it with the warning?

No, it is fine, I will update the log manually.

Thanks

>>> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
>>> ---
>>> drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
>>> index 27a389a7e078..bd63d3484838 100644
>>> --- a/drivers/clocksource/timer-microchip-pit64b.c
>>> +++ b/drivers/clocksource/timer-microchip-pit64b.c
>>> @@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
>>> if (!pclk_rate)
>>> return -EINVAL;
>>>
>>> + timer->mode = 0;
>>> +
>>> /* Try using GCLK. */
>>> gclk_round = clk_round_rate(timer->gclk, max_rate);
>>> if (gclk_round < 0)
>>> @@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
>>> bool clkevt)
>>> {
>>> u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
>>> - struct mchp_pit64b_timer timer = { 0 };
>>> + struct mchp_pit64b_timer timer;
>>> unsigned long clk_rate;
>>> u32 irq = 0;
>>> int ret;
>>>
>>
>>
>> --
>> <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs
>>
>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>> <http://twitter.com/#!/linaroorg> Twitter |
>> <http://www.linaro.org/linaro-blog/> Blog
>>


--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog