Re: [EXT] [PATCH net-next v4 15/15] net: macsec: add support for offloading to the MAC

[Antoine Tenart]

Hi Igor,

On Mon, Dec 23, 2019 at 11:36:48AM +0000, Igor Russkikh wrote:
> 
> > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> > index 024af2d1d0af..771371d5b996 100644
> > --- a/include/uapi/linux/if_link.h
> > +++ b/include/uapi/linux/if_link.h
> > @@ -489,6 +489,7 @@ enum macsec_validation_type {
> >  enum macsec_offload {
> >  	MACSEC_OFFLOAD_OFF = 0,
> >  	MACSEC_OFFLOAD_PHY = 1,
> > +	MACSEC_OFFLOAD_MAC = 2,
> >  	__MACSEC_OFFLOAD_END,
> >  	MACSEC_OFFLOAD_MAX = __MACSEC_OFFLOAD_END - 1,
> 
> So from uapi perspective user have to explicitly specify "offload mac"
> or "offload phy"? And from non experienced user perspective he always
> have to try these two before rolling back to "offload none" ?
> 
> I'm not saying this is wrong, just trying to understand if there any
> more streamlined way to do this..

That is the idea, the commands will be:
# ip macsec offload macsec0 off
# ip macsec offload macsec0 phy
# ip macsec offload macsec0 mac

We should be able to report what's supported for a given interface, for
a more user friendly experience though. (We could include the
information in `ip macsec show` for example). Would that improve things?

Thanks!
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com