Re: [PATCH v2 34/36] platform/x86: intel_pmc_ipc: Convert to MFD

[Andy Shevchenko]

On Thu, Jan 09, 2020 at 02:57:27PM +0200, Mika Westerberg wrote:
> On Thu, Jan 09, 2020 at 01:47:59PM +0200, Mika Westerberg wrote:
> > > >  config INTEL_SOC_PMIC_BXTWC
> > > >  	tristate "Support for Intel Broxton Whiskey Cove PMIC"
> > > > -	depends on INTEL_PMC_IPC
> > > > +	depends on MFD_INTEL_PMC_BXT
> > > >  	select MFD_CORE
> > > >  	select REGMAP_IRQ
> > > >  	help
> > > > @@ -632,6 +632,18 @@ config MFD_INTEL_MSIC
> > > >  	  Passage) chip. This chip embeds audio, battery, GPIO, etc.
> > > >  	  devices used in Intel Medfield platforms.
> > > >  
> > > > +config MFD_INTEL_PMC_BXT
> > > > +	tristate "Intel PMC Driver for Broxton"
> > > 
> > > > +	depends on X86 && X86_PLATFORM_DEVICES && ACPI
> > > 
> > > Is the X86_PLATFORM_DEVICES dependency compulsory?
> > > Quick grep shows that none of drivers (except nouveau) relies on it.
> > 
> > Well, we need that to be able to do the "select INTEL_SCU_IPC" below.
> > I'm happy to change it if you have a better alternative ;-)
> 
> Just to provide more information. If I don't have that dependency I get
> warnings like this:
> 
> WARNING: unmet direct dependencies detected for INTEL_SCU_IPC
>   Depends on [n]: X86 [=y] && X86_PLATFORM_DEVICES [=n]
>     Selected by [y]:
>       - MFD_INTEL_PMC_BXT [=y] && HAS_IOMEM [=y] && X86 [=y] && ACPI [=y]

I see, thanks for elaboration.
Please, just split them one per line.

-- 
With Best Regards,
Andy Shevchenko