Re: [PATCH v3 1/2] dt-bindings: Documentation for qcom,eud

[Dwivedi, Avaneesh Kumar (avani)]

On 11/17/2018 8:17 PM, Rob Herring wrote:
> On Thu, Nov 15, 2018 at 11:32:53AM -0800, Prakruthi Deepak Heragu wrote:
> > Documentation for Embedded USB Debugger (EUD) device tree bindings.
> I asked questions on v2 which were never answered.

HI Rob,

Can you please review my replies against your comments on patchset v2?

> > Signed-off-by: Satya Durga Srinivasu Prabhala <satyap@xxxxxxxxxxxxxx>
> > Signed-off-by: Prakruthi Deepak Heragu <pheragu@xxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/soc/qcom/qcom,msm-eud.txt  | 43 ++++++++++++++++++++++
> >   1 file changed, 43 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
> >
> > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
> > new file mode 100644
> > index 0000000..6d339e7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
> > @@ -0,0 +1,43 @@
> > +* Qualcomm Technologies Inc Embedded USB Debugger (EUD)
> > +
> > +The EUD (Embedded USB Debugger) is a mini-USB hub implemented
> > +on chip to support the USB-based debug and trace capabilities.
> > +
> > +Required properties:
> > +
> > + - compatible:  Should be "qcom,msm-eud"
> > + - interrupts:  Interrupt number
> > + - reg: Should be address and size of EUD register space
> > +
> > +EUD notifies clients for VBUS attach/detach and charger enable/disable
> > +events. The link between client and EUD is established via a directed
> > +graph. EUD has one endpoint of the graph link mentioning EUD as an
> > +output link and clients of EUD should have the other endpoint of the
> > +graph link as an input link.
> > +
> > +An example for EUD device node:
> > +
> > +	eud: qcom,msm-eud@88e0000 {
> > +		compatible = "qcom,msm-eud";
> > +		interrupts = <GIC_SPI 492 IRQ_TYPE_LEVEL_HIGH>;
> > +		reg = <0x88e0000 0x4000>;
> > +		usb_con: connector {
> > +                compatible = "usb-c-connector";
> > +                label = "USB-C";
> > +                port {
> > +                	    eud_usb_output: endpoint {
> > +                        	    remote-endpoint = <&eud_usb3_input>;
> > +                        };
> > +        	    };
> > +        };
> > +	};
> > +
> > +An example for EUD client:
> > +
> > +	usb3 {
> > +		port {
> > +                eud_usb3_input: endpoint {
> > +                        remote-endpoint = <&eud_usb_output>;
> > +                };
> > +        };
> > +	};
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.