Re: [PATCH] kconfig: fix an "implicit declaration of function" warning

[Bartosz Golaszewski]

czw., 9 sty 2020 o 16:59 Masahiro Yamada <masahiroy@xxxxxxxxxx> napisaÅ(a):
>
> On Thu, Jan 9, 2020 at 9:56 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> >
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > strncasecmp() & strcasecmp() functions are declared in strings.h, not
> > string.h. On most environments the former is implicitly included by
> > the latter but on some setups, building menuconfig results in the
> > following warning:
> >
> >   HOSTCC  scripts/kconfig/mconf.o
> > scripts/kconfig/mconf.c: In function âsearch_confâ:
> > scripts/kconfig/mconf.c:423:6: warning: implicit declaration of function âstrncasecmpâ [-Wimplicit-function-declaration]
> >   if (strncasecmp(dialog_input_result, CONFIG_, strlen(CONFIG_)) == 0)
> >       ^~~~~~~~~~~
> > scripts/kconfig/mconf.c: In function âmainâ:
> > scripts/kconfig/mconf.c:1021:8: warning: implicit declaration of function âstrcasecmpâ [-Wimplicit-function-declaration]
> >    if (!strcasecmp(mode, "single_menu"))
> >         ^~~~~~~~~~
> >
> > Fix it by explicitly including strings.h.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> Thanks.
>
> I see strncasecmp() in
> scripts/kconfig/nconf.c too.
>
> Could you fix both in a single patch?
>
> You can try it with "make nconfig".

Sure. It seems gconf needs the same change too.

Bart