Re: [PATCH] drm/fb-cma-helpers: Fix include issue

From: Benjamin Gaignard
Date: Thu Jan 09 2020 - 11:34:06 EST


Le jeu. 9 janv. 2020 Ã 17:29, Benjamin GAIGNARD
<benjamin.gaignard@xxxxxx> a Ãcrit :
>
>
> On 12/3/19 5:49 PM, Benjamin Gaignard wrote:
> > Le mer. 20 nov. 2019 Ã 00:28, Benjamin Gaignard
> > <benjamin.gaignard@xxxxxx> a Ãcrit :
> >> Exported functions prototypes are missing in drm_fb_cma_helper.c
> >> Include drm_fb_cma_helper to fix that issue.
> >>
> > Gentle ping to reviewers.
> > Thanks,
> > Benjamin
>
> I know that removing warnings is not a sexy task, but reviewers are welcome.

Applied on drm-misc-next, with Thomas ack even if dri patchwork doesn't show it.

Thanks
Benjamin

>
> Thanks,
>
> Benjamin
>
> >
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
> >> ---
> >> drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
> >> include/drm/drm_fb_cma_helper.h | 2 ++
> >> 2 files changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> >> index c0b0f603af63..9801c0333eca 100644
> >> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> >> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> >> @@ -9,6 +9,7 @@
> >> * Copyright (C) 2012 Red Hat
> >> */
> >>
> >> +#include <drm/drm_fb_cma_helper.h>
> >> #include <drm/drm_fourcc.h>
> >> #include <drm/drm_framebuffer.h>
> >> #include <drm/drm_gem_cma_helper.h>
> >> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
> >> index 4becb09975a4..795aea1d0a25 100644
> >> --- a/include/drm/drm_fb_cma_helper.h
> >> +++ b/include/drm/drm_fb_cma_helper.h
> >> @@ -2,6 +2,8 @@
> >> #ifndef __DRM_FB_CMA_HELPER_H__
> >> #define __DRM_FB_CMA_HELPER_H__
> >>
> >> +#include <linux/types.h>
> >> +
> >> struct drm_framebuffer;
> >> struct drm_plane_state;
> >>
> >> --
> >> 2.15.0
> >>
> >> _______________________________________________
> >> dri-devel mailing list
> >> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> >> https://lists.freedesktop.org/mailman/listinfo/dri-devel