Re: [PATCH] x86/nmi: remove the irqwork from long duration nmi handler

From: Thomas Gleixner
Date: Thu Jan 09 2020 - 15:56:00 EST


Changbin Du <changbin.du@xxxxxxxxx> writes:

> First, printk is NMI context safe now since the safe printk has been
> implemented. The safe printk already has an irqwork to make NMI context
> safe.
>
> Second, the NMI irqwork actually does not work if a NMI handler causes
> panic by watchdog timeout. This NMI irqwork have no chance to run in such
> case, while the safe printk will flush its per-cpu buffer before panic.
>
> Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx>

Looks about right.

Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>