Re: [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton

From: Shuah Khan
Date: Thu Jan 09 2020 - 16:11:14 EST


On 1/9/20 2:00 PM, Daniel W. S. Almeida wrote:
Hi Shuah, thank you for you input!



Looks like there is more code to be added to register/unregister

Just to be clear, attach() is missing, but register / unregister belong in the bridge driver. Is this correct?



Right attach/detach is what I was thinking.


Please add more detail here on what this driver does. What this
driver is used for and so on.


Samehere. Give more details on what this driver does. Add enough detail
to help users decide why they should enable it or not.
General practice is the following.

Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@xxxxxxxxx>

Please add details about the driver similar to the .c file.

OK.


thanks,
-- Shuah