Re: [PATCH v5 00/22] tracing: bootconfig: Boot-time tracing and Extra boot config

[Steven Rostedt]

On Thu, 26 Dec 2019 23:03:48 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> Hello,
> 
> This is the 5th version of the series for the boot-time tracing.
> 
> Previous version is here.
> 
> https://lkml.kernel.org/r/157528159833.22451.14878731055438721716.stgit@devnote2

Hi Masami,

I applied all your patches to a test branch and was playing with it a
little. This seems fine to me and works well (and very easy to use).
Probably could use some more examples, but that's just a nit.

If nobody has any issues with this code, I'll wait for v6 with the
fixes to issues found in this series, and I'll happily apply them for
linux-next.

-- Steve


> 
> In this version, I removed RFC tag from the series.
> Changes from the v4 are here, updating bootconfig things.
> 
>  - [1/22] Fix help comment and indent of Kconfig.
>           Restrict available characters in values(*)
>           Drop backslash escape from quoted value(**)
>  - [3/22] Fix Makefile to compile tool correctly
>           Remove unused pattern from Makefile
>  - [4/22] Show test target bootconfig
>           Add printable value testcases
>           Add bad array testcase
>  - [9/22] Fix TOC list
>           Add notes about available characters.
>           Fix to use correct quotes (``) for .rst.
> 
> (*) this is for preventing admin from shoot himself.
> (**) this rule is from legacy command line.
> 
> Boot-time tracing features are not modified. I know Tom is working
> on exporting synthetic event (and dynamic events) APIs for module.
> If that APIs are merged first, I will update my series on top
> of that.
> 
> This series can be applied on v5.5-rc3 or directly available at;
> 
> https://github.com/mhiramat/linux.git ftrace-boottrace-v5
> 
>