Re: [PATCH v2 1/3] dmaengine: ptdma: Initial driver for the AMD PassThru DMA engine
From: Vinod Koul
Date: Fri Jan 10 2020 - 02:57:20 EST
On 03-01-20, 16:52, Greg KH wrote:
> On Fri, Jan 03, 2020 at 09:12:18AM -0600, Gary R Hook wrote:
> > On 1/3/20 12:26 AM, Vinod Koul wrote:
> > > On 28-12-19, 07:56, kbuild test robot wrote:
> > > > Hi Sanjay,
> > > >
> > > > I love your patch! Perhaps something to improve:
> > >
> > > Please fix the issues reported and also make sure the patches sent are
> > > threaded, right now they are not and the series is all over my inbox :(
> > >
> >
> > What does this mean? The patches showed up in my inbox as a set of 3,
> > properly indexed, just like they should when sent with "git send-email".
> >
> > We've not had any reports from other lists/maintainers of similar problems.
> > So you'll understand how we might be a bit confused.
> >
> > Would you please elaborate on the problem you are seeing?
>
> There was no email threading of the patches, they all looked like
> individual emails. In other words, the "In-Reply-To:" value was not
> set.
And git send-email does that for you if you give it all the patches to
send to... If you give it each patch individually, they will come as
individual units
FWIW, my workflow is
$ git format-patch .... -o <some_dir>
<check the patches, add cover letter details etc>
$ git send-email <some_dir>
That ensures the In-Reply-To is set for subsequent patches and the log
will also tell you that
HTH
--
~Vinod