Re: [PATCH 1/2] regulator: ab8500: Remove AB8505 USB regulator
From: Greg Kroah-Hartman
Date: Fri Jan 10 2020 - 03:16:48 EST
On Fri, Jan 10, 2020 at 01:32:57PM +0530, Naresh Kamboju wrote:
> On Thu, 7 Nov 2019 at 13:32, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> >
> > On Wed, Nov 6, 2019 at 6:33 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote:
> >
> > > The USB regulator was removed for AB8500 in
> > > commit 41a06aa738ad ("regulator: ab8500: Remove USB regulator").
> > > It was then added for AB8505 in
> > > commit 547f384f33db ("regulator: ab8500: add support for ab8505").
> > >
>
> Stable-rc 4.4 branch arm build failed due to this error.
>
> arch/arm/mach-ux500/board-mop500-regulators.c:957:3: error:
> 'AB8505_LDO_USB' undeclared here (not in a function); did you mean
> 'AB9540_LDO_USB'?
> [AB8505_LDO_USB] = {
> ^~~~~~~~~~~~~~
> AB9540_LDO_USB
> arch/arm/mach-ux500/board-mop500-regulators.c:957:3: error: array
> index in initializer not of integer type
> arch/arm/mach-ux500/board-mop500-regulators.c:957:3: note: (near
> initialization for 'ab8505_regulators')
>
> Full build log,
> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.4/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/703/consoleText
>
Good catch, I'll go drop this patch from the 4.4.y queue now, thanks.
greg k-h