Re: [PATCH v1] mfd: syscon: Switch to use devm_ioremap_resource()

From: Andy Shevchenko
Date: Fri Jan 10 2020 - 07:02:48 EST


On Fri, Jan 10, 2020 at 12:40 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Fri, Jan 10, 2020 at 11:15 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > Instead of checking resource pointer for being NULL and
> > report some not very standard error codes in this case,
> > switch to devm_ioremap_resource() API.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> With syscon, I'm worried there are users that map the same region in another
> driver, so doing devm_ioremap_resource() here will make another driver fail.
>
> Maybe just change the error code and add a comment warning about that
> instead?

Oh, yes, you are right.

Thanks for review.

--
With Best Regards,
Andy Shevchenko