Re: [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls

[Wen Yang]

On 2020/1/8 1:25 äå, Julia Lawall wrote:
> > +@depends on context@
> > +expression f;
> > +long l;
> > +unsigned long ul;
> > +u64 ul64;
> > +s64 sl64;
> > +
> > +@@
> > +(
> > +* do_div(f, l);
> > +|
> > +* do_div(f, ul);
> > +|
> > +* do_div(f, ul64);
> > +|
> > +* do_div(f, sl64);
> > +)
>
> This part is not really ideal.  For the reports, you filter for the
> constants, but here you don't do anything.  You can put some python code
> in the matching of the metavariables:
>
> unsigned long ul : script:python() { whatever you want to check on ul };
>
> Then it will only match if the condition is satisfied.
>
> julia

OK, thank you very much.
We'll fix it soon.

--
Best Wishes,
Wen