Re: [PATCH] iwlwifi: fix build warnings with format string
From: Kalle Valo
Date: Fri Jan 10 2020 - 08:16:29 EST
(please cc linux-wireless on all wireless patches)
Akinobu Mita <akinobu.mita@xxxxxxxxx> writes:
> This fixes build warnings introduced by commit "iwlegacy: use
> <linux/units.h> helpers" (iwlegacy-use-linux-unitsh-helpers.patch in -mm)
>
> The format '%d' has to be changed to '%ld' because the return type of
> kelvin_to_celsius() is 'long'.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20200106171452.201c3b4c@xxxxxxxxxxxxxxxx
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: Stanislaw Gruszka <stf_xl@xxxxx>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
I don't know what's Andrew's workflow, but shouldn't the original patch
be fixed instead?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches