Re: [PATCH 13/16] dt-bindings: atmel-usart: add microchip,<chip>-usart

[Alexandre Belloni]

On 08/01/2020 14:55:20+0200, Claudiu Beznea wrote:
> Add microchip,<chip>-usart to DT bindings documentation. This is for
> microchip,sam9x60-usart.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/atmel-usart.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-usart.txt b/Documentation/devicetree/bindings/mfd/atmel-usart.txt
> index 699fd3c9ace8..e5c7331abe09 100644
> --- a/Documentation/devicetree/bindings/mfd/atmel-usart.txt
> +++ b/Documentation/devicetree/bindings/mfd/atmel-usart.txt
> @@ -1,10 +1,12 @@
>  * Atmel Universal Synchronous Asynchronous Receiver/Transmitter (USART)
>  
>  Required properties for USART:
> -- compatible: Should be "atmel,<chip>-usart" or "atmel,<chip>-dbgu"
> +- compatible: Should be "atmel,<chip>-usart", "microchip,<chip>-usart" or
> +  "atmel,<chip>-dbgu".
>    The compatible <chip> indicated will be the first SoC to support an
>    additional mode or an USART new feature.
> -  For the dbgu UART, use "atmel,<chip>-dbgu", "atmel,<chip>-usart"
> +  For the dbgu UART, use "atmel,<chip>-dbgu", "atmel,<chip>-usart",
> +  "microchip,<chip>-usart".

The wildcard here should be eliminated because all the combinations are
not allowed. This would also make it clearer that this change is to
introduce a new IP instead of renamed atmel to microchip.

>  - reg: Should contain registers location and length
>  - interrupts: Should contain interrupt
>  - clock-names: tuple listing input clock names.
> -- 
> 2.7.4
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com