Re: [PATCH 2/2] perf/x86/amd: Add support for Large Increment per Cycle Events

[Peter Zijlstra]

On Fri, Jan 10, 2020 at 10:22:10AM -0600, Kim Phillips wrote:
> On 1/10/20 9:09 AM, Peter Zijlstra wrote:
> > On Wed, Jan 08, 2020 at 04:26:47PM -0600, Kim Phillips wrote:
> >> On 12/20/19 6:09 AM, Peter Zijlstra wrote:
> >>> On Thu, Nov 14, 2019 at 12:37:20PM -0600, Kim Phillips wrote:
> >> One problem I see with your change in the "not already used" fastpath
> >> area, is that the new mask variable gets updated with position 'i'
> >> regardless of any previous Large Increment event assignments.
> > 
> > Urgh, I completely messed that up. Find the below delta (I'll push out a
> > new version to queue.git as well).
> 
> OK, I tested what you pushed on your perf/amd branch, and it passes all my tests.

Excellent!

> BTW, a large part of the commit message went missing, hopefully it'll be brought back before being pushed further upstream?

Argh.. it's those ---- lines, my script things they're cuts. I'll go
fix it up.