Re: [PATCH 0/5] drm/i915: conversion to new drm logging macros.

[Wambui Karuga]

On Fri, 10 Jan 2020, Jani Nikula wrote:

> On Tue, 07 Jan 2020, Wambui Karuga <wambui.karugax@xxxxxxxxx> wrote:
> > This series begins the conversion to using the new struct drm_device
> > based logging macros in drm/i915.
> >
> > Wambui Karuga (5):
> >   drm/i915: convert to using the drm_dbg_kms() macro.
> >   drm/i915: use new struct drm_device logging macros.
> >   drm/i915: use new struct drm_device based logging macros.
> >   drm/i915: convert to using new struct drm_device logging macros
> >   drm/i915: use new struct drm_device based macros.
>
> Thanks for the patches, pushed to drm-intel-next-queued.
>
> As it's impossible to distinguish the commits from each other by the
> subject line alone, I've amended the prefix while pushing as follows:
>
> drm/i915/pch: convert to using the drm_dbg_kms() macro.
> drm/i915/pm: use new struct drm_device logging macros.
> drm/i915/lmem: use new struct drm_device based logging macros.
> drm/i915/sideband: convert to using new struct drm_device logging macros
> drm/i915/uncore: use new struct drm_device based macros.
>
> Please pay attention to this in future work. It's not always obvious
> what the prefix should be, but 'git log -- path/to/file.c' will go a
> long way.
Sure, I'll do that from now on.
Thanks.
> BR,
> Jani.
>
>
> >  drivers/gpu/drm/i915/intel_pch.c         |  46 +--
> >  drivers/gpu/drm/i915/intel_pm.c          | 351 +++++++++++++----------
> >  drivers/gpu/drm/i915/intel_region_lmem.c |  10 +-
> >  drivers/gpu/drm/i915/intel_sideband.c    |  29 +-
> >  drivers/gpu/drm/i915/intel_uncore.c      |  25 +-
> >  5 files changed, 254 insertions(+), 207 deletions(-)
>
> --
> Jani Nikula, Intel Open Source Graphics Center