Re: [tip: x86/mm] mm/vmalloc: Add empty <asm/vmalloc.h> headers and use them from <linux/vmalloc.h>

[Geert Uytterhoeven]

Hi Ingo,

On Fri, Jan 10, 2020 at 7:00 PM tip-bot2 for Ingo Molnar
<tip-bot2@xxxxxxxxxxxxx> wrote:
> The following commit has been merged into the x86/mm branch of tip:
>
> Commit-ID:     1f059dfdf5d170dccbac92193be2fee3c1763384
> Gitweb:        https://git.kernel.org/tip/1f059dfdf5d170dccbac92193be2fee3c1763384
> Author:        Ingo Molnar <mingo@xxxxxxxxxx>
> AuthorDate:    Thu, 28 Nov 2019 08:19:36 +01:00
> Committer:     Ingo Molnar <mingo@xxxxxxxxxx>
> CommitterDate: Tue, 10 Dec 2019 10:12:55 +01:00
>
> mm/vmalloc: Add empty <asm/vmalloc.h> headers and use them from <linux/vmalloc.h>
>
> In the x86 MM code we'd like to untangle various types of historic
> header dependency spaghetti, but for this we'd need to pass to
> the generic vmalloc code various vmalloc related defines that
> customarily come via the <asm/page.h> low level arch header.

<asm/vmalloc.h>?

> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> ---
>  arch/alpha/include/asm/vmalloc.h      | 4 ++++

Why not include/asm-generic/vmalloc.h, and add

    generic-y += vmalloc.h

in each arch/*/include/asm/Kbuild?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds