Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives

From: Guenter Roeck
Date: Sat Jan 11 2020 - 15:23:28 EST


On 1/8/20 7:33 AM, Guenter Roeck wrote:
On Tue, Jan 07, 2020 at 08:12:06PM -0500, Martin K. Petersen wrote:

Guenter,

Any idea how I might be able to reproduce this ? So far I have been
unsuccessful.

Building drivetemp into the kernel, with ahci and everything SCSI
built as module, doesn't trigger the crash for me. This is with the
drivetemp patch (v3) as well as commit d188b0675b ("scsi: core: Add
sysfs attributes for VPD pages 0h and 89h") applied on top of v5.4.7.

This is with 5.5-rc1. I'll try another kernel.

My repro is:

# modprobe drivetemp
# modprobe <any SCSI driver, including ahci>

No luck on my side. Can you provide a traceback ? Maybe we can use it
to find out what is happening.


I tried again, this time with v5.5-rc5. Loading and unloading ahci and
drivetemp in any order does not cause any problems for me.

At this point I don't know what else I could test. I went ahead and
applied the drivetemp patch to hwmon-next. Maybe we'll get some additional
test feedback this way.

Guenter