[PATCH] sched/uclamp: reject negative values in cpu_uclamp_write

From: Qais Yousef
Date: Sun Jan 12 2020 - 18:55:02 EST


The check to ensure that the new written value into cpu.uclamp.{min,max}
is within range, [0:100], wasn't working because of the signed
comparison

7301 if (req.percent > UCLAMP_PERCENT_SCALE) {
7302 req.ret = -ERANGE;
7303 return req;
7304 }

Cast req.percent into u64 to force the comparison to be unsigned and
work as intended in capacity_from_percent().

Fixes: 2480c093130f ("sched/uclamp: Extend CPU's cgroup controller")
Signed-off-by: Qais Yousef <qais.yousef@xxxxxxx>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 90e4b00ace89..e66b131e3aeb 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7254,7 +7254,7 @@ capacity_from_percent(char *buf)
&req.percent);
if (req.ret)
return req;
- if (req.percent > UCLAMP_PERCENT_SCALE) {
+ if ((u64)req.percent > UCLAMP_PERCENT_SCALE) {
req.ret = -ERANGE;
return req;
}
--
2.17.1