Re: [PATCH] ubifs: Fix potentially out-of-bounds memory access inubifs_dump_node

From: Richard Weinberger
Date: Mon Jan 13 2020 - 03:30:47 EST


----- UrsprÃngliche Mail -----
> Although this will change a bit more, but the function of dumping data is
> retained,
> I will modify it as suggested and try to submit a patch, thanks.

Sure but the most common and important case is good then.
in fs/ubifs/file.c we use a fixed buffer size of UBIFS_MAX_DATA_NODE_SZ
to deal with data nodes. So, dumping is safe.

If we don't know the buffer size for minor cases, not a big deal.
Still better than giving up the feature completely.

Thanks,
//richard