Re: [PATCH RFC net-next 00/20] net: dsa: add GRO support

From: Alexander Lobakin
Date: Mon Jan 13 2020 - 04:25:37 EST


Andrew Lunn wrote 30.12.2019 20:12:
I mark this as RFC, and there are the key questions for maintainers,
developers, users etc.:
- Do we need GRO support for DSA at all?

- Does this series bring any performance improvements on the
affected systems?

Hi Alexander

Hi,

I think these are the two most important questions. Did you do any
performance testing for the hardware you have?

Exactly, this are the top questions. I performed lots of tests on
hardware with which I'm working on and had a pretty good boosts
(I didn't mainlined my drivers yet unfortunately).
But this does not mean that GRO would be that nice for all kind of
devices *at all*. That's why I would like to see more test results
on different systems.

I personally don't have any of the switches you have made
modifications to, so i cannot test these patches. I might be able to
add GRO to DSA and EDSA, where i can do some performance testing.

Andrew

Regards,
á á á á á á