Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver

From: John Garry
Date: Mon Jan 13 2020 - 08:01:11 EST


On 13/01/2020 11:42, Mark Brown wrote:
On Mon, Jan 13, 2020 at 10:09:27AM +0000, John Garry wrote:
On 10/01/2020 19:31, Andy Shevchenko wrote:

PRP method is only for vendors to *test* the hardware in ACPI environment.
The proper method is to allocate correct ACPI ID.

Yes, that would seem the proper thing to do. So the SPI NOR driver is based
on micron m25p80 and compatible string is "jedec,spi-nor", so I don't know
who should or would do this registration.


Hi Mark,

The idiomatic approach appears to be for individual board vendors
to allocate IDs, you do end up with multiple IDs from multiple
vendors for the same thing.

So we see sort of approach a lot when vendors integrate 3rd party IP into a SoC and then assign some vendor specific ID for that.

But I am not sure how appropriate that same approach would be for some 3rd party memory part which we're simply wiring up on our board. Maybe it is.


BTW, Do any of these sensors you mention have any ACPI standardization?

In general there's not really much standardizaiton for devices,
the bindings that do exist aren't really centrally documented and
the Windows standard is just to have the basic device
registration in the firmware and do all properties based on
quirking based on DMI information.


OK, so there is always DMI. I hoped to avoid this sort of thing in the linux driver :)

Cheers,
John