Re: [PATCH net-next v5 02/15] net: macsec: introduce the macsec_context structure

[Jiri Pirko]

Fri, Jan 10, 2020 at 05:19:57PM CET, antoine.tenart@xxxxxxxxxxx wrote:

[...]


>diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
>index 1d69f637c5d6..024af2d1d0af 100644
>--- a/include/uapi/linux/if_link.h
>+++ b/include/uapi/linux/if_link.h
>@@ -486,6 +486,13 @@ enum macsec_validation_type {
> 	MACSEC_VALIDATE_MAX = __MACSEC_VALIDATE_END - 1,
> };
> 
>+enum macsec_offload {
>+	MACSEC_OFFLOAD_OFF = 0,
>+	MACSEC_OFFLOAD_PHY = 1,

No need to assign 0, 1 here. That is given.


>+	__MACSEC_OFFLOAD_END,
>+	MACSEC_OFFLOAD_MAX = __MACSEC_OFFLOAD_END - 1,
>+};
>+
> /* IPVLAN section */
> enum {
> 	IFLA_IPVLAN_UNSPEC,
>diff --git a/tools/include/uapi/linux/if_link.h b/tools/include/uapi/linux/if_link.h
>index 8aec8769d944..42efdb84d189 100644
>--- a/tools/include/uapi/linux/if_link.h
>+++ b/tools/include/uapi/linux/if_link.h

Why you are adding to this header?


>@@ -485,6 +485,13 @@ enum macsec_validation_type {
> 	MACSEC_VALIDATE_MAX = __MACSEC_VALIDATE_END - 1,
> };
> 
>+enum macsec_offload {
>+	MACSEC_OFFLOAD_OFF = 0,
>+	MACSEC_OFFLOAD_PHY = 1,
>+	__MACSEC_OFFLOAD_END,
>+	MACSEC_OFFLOAD_MAX = __MACSEC_OFFLOAD_END - 1,
>+};
>+
> /* IPVLAN section */
> enum {
> 	IFLA_IPVLAN_UNSPEC,
>-- 
>2.24.1
>