Re: [PATCH 3/5] ARC: handle DSP presence in HW

From: Vineet Gupta
Date: Mon Jan 13 2020 - 11:49:30 EST


On 1/10/20 6:54 AM, Eugeniy Paltsev wrote:
>
>>> + CHK_OPT_STRICT(CONFIG_ARC_DSP_KERNEL, present);
>>> }
> My idea here is to encapsulate implementation of everything dsp-related in the
> file with dsp code. So I'm even thinking about moving the config check itself
> to some function like
> 'arc_chk_dsp_config' which will be located in dsp.x file
> and call it from arc_chk_core_config in setup.c
>
> This requires to move config check helpers to separate file/header from the setup.c
> However this allows encapsulate all DSP code (and some new subsystems code later on) in its files instead of spread it across the arc code.
>
> What do you think about it? If you really dislike this idea I can drop it.

Ok makes sense then !

-Vineet