Re: [PATCH v3 2/3] dt-binding: hwmon: Add documentation for ADM1177
From: Rob Herring
Date: Mon Jan 13 2020 - 12:00:00 EST
On Tue, Jan 7, 2020 at 4:58 AM Beniamin Bia <beniamin.bia@xxxxxxxxxx> wrote:
>
> Documentation for ADM1177 was added.
>
> Signed-off-by: Beniamin Bia <beniamin.bia@xxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> Changes in v3:
> -nothing changed
>
> .../bindings/hwmon/adi,adm1177.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml
This is breaking linux-next. Please fix and run 'make dt_binding_check':
Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml: while
scanning a block scalar
in "<unicode string>", line 51, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 61, column 1
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml
> new file mode 100644
> index 000000000000..65ef95328bc6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/adi,adm1177.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADM1177 Hot Swap Controller and Digital Power Monitor
> +
> +maintainers:
> + - Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> + - Beniamin Bia <beniamin.bia@xxxxxxxxxx>
> +
> +description: |
> + Analog Devices ADM1177 Hot Swap Controller and Digital Power Monitor
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1177.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adm1177
> +
> + reg:
> + maxItems: 1
> +
> + avcc-supply:
> + description:
> + Phandle to the Avcc power supply
> +
> + shunt-resistor-micro-ohms:
> + description:
> + The value of curent sense resistor in microohms. If not provided,
> + the current reading and overcurrent alert is disabled.
> +
> + adi,shutdown-threshold-microamp:
> + description:
> + Specifies the current level at which an over current alert occurs.
> + If not provided, the overcurrent alert is configured to max ADC range
> + based on shunt-resistor-micro-ohms.
> +
> + adi,vrange-high-enable:
> + description:
> + Specifies which internal voltage divider to be used. A 1 selects
> + a 7:2 voltage divider while a 0 selects a 14:1 voltage divider.
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pwmon@5a {
> + compatible = "adi,adm1177";
> + reg = <0x5a>;
> + shunt-resistor-micro-ohms = <50000>; /* 50 mOhm */
> + adi,shutdown-threshold-microamp = <1059000>; /* 1.059 A */
> + adi,vrange-high-enable;
> + };
> + };
> +...
> --
> 2.17.1
>