Re: Re: [PATCH V2 3/5] PCI: tegra: Add support for PCIe endpoint mode in Tegra194

[Vidya Sagar]

On 1/6/20 6:44 PM, Thierry Reding wrote:
> On Fri, Jan 03, 2020 at 06:14:02PM +0530, Vidya Sagar wrote:
> > Add support for the endpoint mode of Synopsys DesignWare core based
> > dual mode PCIe controllers present in Tegra194 SoC.
> >
> > Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
> > ---
> > V2:
> > * Addressed Bjorn's review comments
> > * Made changes as part of addressing review comments for other patches
> >
> >   drivers/pci/controller/dwc/Kconfig         |  30 +-
> >   drivers/pci/controller/dwc/pcie-tegra194.c | 782 ++++++++++++++++++++-
> >   2 files changed, 796 insertions(+), 16 deletions(-)
> [...]
> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> > index cbe95f0ea0ca..6621ac79efee 100644
> > --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> [...]
> > @@ -1427,8 +1620,553 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie)
> [...]
> > +static int tegra_pcie_config_ep(struct tegra_pcie_dw *pcie,
> > +				struct platform_device *pdev)
> > +{
> [...]
> > +	ret = devm_request_irq(dev, pcie->pex_rst_irq,
> > +			       tegra_pcie_ep_pex_rst_irq,
> > +			       IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> > +			       name, (void *)pcie);
> > +	if (ret < 0) {
> > +		dev_err(dev, "Failed to request IRQ for PERST: %d\n", ret);
> > +		return ret;
> > +	}
> > +	disable_irq(pcie->pex_rst_irq);
>
> I just came across this while reviewing another patch: it looks like a
> better way to handle "disabled by default" interrupts is to do this:
>
> 	irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN);
>
> before calling devm_request_irq(). See here for an example:
>
> 	http://patchwork.ozlabs.org/patch/1217944/
I'll take care of it.

Thanks for the review.
Vidya Sagar

> Thierry