Re: [PATCH v3] xen-pciback: optionally allow interrupt enable flag writes

[Marek Marczykowski-GÃrecki]

On Mon, Jan 13, 2020 at 04:25:02PM -0500, Boris Ostrovsky wrote:
> 
> 
> On 1/10/20 10:43 PM, Marek Marczykowski-GÃrecki wrote:
> > @@ -117,6 +117,24 @@ static int command_write(struct pci_dev *dev, int offset, u16 value, void *data)
> >   		pci_clear_mwi(dev);
> >   	}
> > +	if (dev_data && dev_data->allow_interrupt_control) {
> > +		if ((cmd->val ^ val) & PCI_COMMAND_INTX_DISABLE) {
> > +			if (value & PCI_COMMAND_INTX_DISABLE) {
> > +				pci_intx(dev, 0);
> > +			} else {
> > +				/* Do not allow enabling INTx together with MSI or MSI-X. */
> > +				switch (xen_pcibk_get_interrupt_type(dev)) {
> > +				case INTERRUPT_TYPE_NONE:
> > +				case INTERRUPT_TYPE_INTX:
> > +					pci_intx(dev, 1);
> 
> If INTERRUPT_TYPE_INTX , why call pci_intx(1)?

Not needed indeed.

> 
> (I think I asked this last time as well).
> 
> 
> -boris
> 
> 

-- 
Best Regards,
Marek Marczykowski-GÃrecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature