regulator: mpq7920: Some inconsistencies in current driver
From: Axel Lin
Date: Tue Jan 14 2020 - 07:49:30 EST
Hi Saravanan,
There are a few inconsistencies in current driver:
I don't have the datasheet, so I'm not 100% sure.
Maybe you can help check it.
1. It's unlikely MPQ7920_LDO1_REG_B and MPQ7920_REG_CTL0 have the same address.
I think this needs double check.
2. The MPQ7920_DISCHARGE_ON seems wrong because it does not match
MPQ7920_MASK_DISCHARGE.
I guess MPQ7920_DISCHARGE_ON should be BIT(5).
3. The MPQ7920_MASK_BUCK_ILIM seems wrong. I guess it should be 0xC0.
4. Not sure why define both MPQ7920_REG_REGULATOR_EN1 and
MPQ7920_REG_REGULATOR_EN.
Regards,
Axel