Re: [PATCH 2/2] libertas: make lbs_ibss_join_existing() return error code on rates overflow

From: Kalle Valo
Date: Tue Jan 14 2020 - 08:44:45 EST


Nicolai Stange <nstange@xxxxxxx> writes:

> Commit e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss
> descriptor") introduced a bounds check on the number of supplied rates to
> lbs_ibss_join_existing() and made it to return on overflow.
>
> However, the aforementioned commit doesn't set the return value accordingly
> and thus, lbs_ibss_join_existing() would return with zero even though it
> failed.
>
> Make lbs_ibss_join_existing return -EINVAL in case the bounds check on the
> number of supplied rates fails.
>
> Fixes: e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss
> descriptor")

This should be in one line, I'll fix it during commit.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches