Re: [PATCH 2/2] perf/ui/gtk: Fix gtk2 build

[Arnaldo Carvalho de Melo]

Em Mon, Jan 13, 2020 at 11:43:58AM +0100, Jiri Olsa escreveu:
> Ravi Bangoria reported issue when detecting gtk2 on Fedora 31,
> where some types got deprecated:
> 
>   /usr/include/gtk-2.0/gtk/gtktypeutils.h:236:1: error: âGTypeDebugFlagsâ is deprecated [-Werror=deprecated-declarations]
>     236 | void            gtk_type_init   (GTypeDebugFlags    debug_flags);
> 
> Fixing this for perf by allowing the compile to pass
> with deprecated symbols via -Wno-deprecated-declarations.

Thanks, applied.

- Arnaldo
 
> Reported-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>
> Tested-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>
> Link: https://lkml.kernel.org/n/tip-kg8fqsa0bgq3suc9ubonh4xu@xxxxxxxxxxxxxx
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
>  tools/build/feature/Makefile | 2 +-
>  tools/perf/ui/gtk/Build      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
> index f30a89046aa3..7ac0d8088565 100644
> --- a/tools/build/feature/Makefile
> +++ b/tools/build/feature/Makefile
> @@ -197,7 +197,7 @@ $(OUTPUT)test-libcrypto.bin:
>  	$(BUILD) -lcrypto
>  
>  $(OUTPUT)test-gtk2.bin:
> -	$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)
> +	$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) -Wno-deprecated-declarations
>  
>  $(OUTPUT)test-gtk2-infobar.bin:
>  	$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)
> diff --git a/tools/perf/ui/gtk/Build b/tools/perf/ui/gtk/Build
> index 9b5d5cbb7af7..eef708c502f4 100644
> --- a/tools/perf/ui/gtk/Build
> +++ b/tools/perf/ui/gtk/Build
> @@ -1,4 +1,4 @@
> -CFLAGS_gtk += -fPIC $(GTK_CFLAGS)
> +CFLAGS_gtk += -fPIC $(GTK_CFLAGS) -Wno-deprecated-declarations
>  
>  gtk-y += browser.o
>  gtk-y += hists.o
> -- 
> 2.24.1
> 

-- 

- Arnaldo