Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST

[Randy Dunlap]

Hi Alan,

On 1/14/20 8:09 AM, Alan Maguire wrote:
> currently the property entry kunit tests are built if CONFIG_KUNIT=y.
> This will cause warnings when merged with the kunit tree that now
> supports tristate CONFIG_KUNIT.  While the tests appear to compile
> as a module, we get a warning about missing module license.
> 
> It's better to have a per-test suite CONFIG variable so that
> we can do selective building of kunit-based suites, and can
> also avoid merge issues like this.
> 
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

> Fixes: c032ace71c29 ("software node: add basic tests for property entries")
> Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx>
> ---
>  drivers/base/test/Kconfig  | 3 +++
>  drivers/base/test/Makefile | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
> index 86e85da..d29ae95 100644
> --- a/drivers/base/test/Kconfig
> +++ b/drivers/base/test/Kconfig
> @@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
>  	  The module name will be test_async_driver_probe.ko
>  
>  	  If unsure say N.
> +config KUNIT_DRIVER_PE_TEST
> +	bool "KUnit Tests for property entry API"
> +	depends on KUNIT

Why is this bool instead of tristate?

> diff --git a/drivers/base/test/Makefile b/drivers/base/test/Makefile
> index 2214310..3ca5636 100644
> --- a/drivers/base/test/Makefile
> +++ b/drivers/base/test/Makefile
> @@ -1,4 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0
>  obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE)	+= test_async_driver_probe.o
>  
> -obj-$(CONFIG_KUNIT) += property-entry-test.o
> +obj-$(CONFIG_KUNIT_DRIVER_PE_TEST) += property-entry-test.o
> 

thanks.
-- 
~Randy