Re: [PATCH v10 00/14] add the latest exfat driver

From: Pali RohÃr
Date: Wed Jan 15 2020 - 04:47:37 EST


Hello! I have reviewed all changes in time when v10 has been preparing.

There is just a small issue with description of EXFAT_DEFAULT_IOCHARSET
option (see email). Otherwise it looks good you can add my Reviewed-by
on whole patch series.

Reviewed-by: Pali RohÃr <pali.rohar@xxxxxxxxx>

Next steps for future:

* De-duplicate cache code between fat and exfat. Currently fs/exfat
cache code is heavily copy-paste of fs/fat cache code.

* De-duplicate UTF-16 functions. Currently fs/exfat has e.g. helper
functions for surrogate pairs copy-paste from fs/nls.

* Unify EXFAT_DEFAULT_IOCHARSET and FAT_DEFAULT_IOCHARSET. Or maybe
unify it with other filesystems too.

* After applying this patch series, remote staging exfat implementation.

--
Pali RohÃr
pali.rohar@xxxxxxxxx