Re: [PATCH] fs/ext4: remove MPAGE_DA_EXTENT_TAIL

From: Jan Kara
Date: Wed Jan 15 2020 - 05:17:12 EST


On Wed 15-01-20 17:51:28, Alex Shi wrote:
> After commit 4e7ea81db534 ("ext4: restructure writeback path"), this
> macro isn't used anymore. so better to remove it.
>
> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx>
> Cc: "Theodore Ts'o" <tytso@xxxxxxx>
> Cc: Jan Kara <jack@xxxxxxx>
> Cc: Andreas Dilger <adilger.kernel@xxxxxxxxx>
> Cc: linux-ext4@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

Thanks for the patch but I think Ted already merged a very similar cleanup
into his tree.

Honza

> ---
> fs/ext4/inode.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 629a25d999f0..bb2d8c9205b7 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -48,8 +48,6 @@
>
> #include <trace/events/ext4.h>
>
> -#define MPAGE_DA_EXTENT_TAIL 0x01
> -
> static __u32 ext4_inode_csum(struct inode *inode, struct ext4_inode *raw,
> struct ext4_inode_info *ei)
> {
> --
> 1.8.3.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR