Re: [PATCH 7/7] devfreq: move statistics to separate struct

From: Bartlomiej Zolnierkiewicz
Date: Wed Jan 15 2020 - 10:56:26 EST



On 12/16/19 2:01 PM, Lukasz Luba wrote:
> Hi Bartek,
>
> [added Dietmar, Robin, Andrzej (for upcoming DRM drm-misc-next)]
>
> On 11/15/19 12:40 PM, Bartlomiej Zolnierkiewicz wrote:

[...]

>> Hmmm.. fixing partition_enable_opps() should be trivial but I wonder
>> why we are carrying devfreq_cooling.c code in upstream kernel at all?
>
> Well, the devfreq_cooling.c is going to have a client in mainline:
> the GPU driver - Panfrost.
>
> It is already in DRM branch 'drm-misc-next':
> https://patchwork.freedesktop.org/patch/342848/

OK, thanks for explaining this.

> Regarding the devfreq_cooling.c code structure.
> I am currently working on cleaning up the devfreq cooling code and
> adding Energy Model instead for private freq, power tables. It will be
> in similar fashion as it is done in cpufreq_cooling. The model will
> be also simplified so hopefully more clients would come.
> It is under internal review and will be posted shortly.

Great to hear this and thank you for working on it.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics