Re: [PATCH v2 3/4] i2c: highlander: Use proper printk format for iomem pointer

[Wolfram Sang]

On Tue, Jan 14, 2020 at 10:06:04AM +0100, Krzysztof Kozlowski wrote:
> iomem pointers should be printed with pointer format to hide the
> actual value and fix warnings when compiling on 64-bit platform (e.g. with
> COMPILE_TEST):
> 
>     drivers/i2c/busses/i2c-highlander.c: In function âhighlander_i2c_smbus_xferâ:
>     drivers/i2c/busses/i2c-highlander.c:325:22: warning:
>         format â%dâ expects argument of type âintâ,
>         but argument 3 has type âsize_t {aka long unsigned int}â [-Wformat=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Wrong commit message. buf_len is size_t and not an iomem pointer.

> ---
> 
> Changes since v1:
> 1. None
> ---
>  drivers/i2c/busses/i2c-highlander.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-highlander.c b/drivers/i2c/busses/i2c-highlander.c
> index abfe3094c047..803dad70e2a7 100644
> --- a/drivers/i2c/busses/i2c-highlander.c
> +++ b/drivers/i2c/busses/i2c-highlander.c
> @@ -322,7 +322,7 @@ static int highlander_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr,
>  		tmp |= (SMMR_MODE0 | SMMR_MODE1);
>  		break;
>  	default:
> -		dev_err(dev->dev, "unsupported xfer size %d\n", dev->buf_len);
> +		dev_err(dev->dev, "unsupported xfer size %zu\n", dev->buf_len);
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.7.4
>

Attachment: signature.asc
Description: PGP signature