Re: [PATCH v5 1/2] mm: make dev_pagemap_mapping_shift() externally visible

[Paolo Bonzini]

On 16/12/19 18:59, Barret Rhoden wrote:
> Does KVM-x86 need its own names for the levels? If not, I could convert
> the PT_PAGE_TABLE_* stuff to PG_LEVEL_* stuff.

Yes, please do.  For the 2M/4M case, it's only incorrect to use 2M here:

        if (PTTYPE == 32 && walker->level == PT_DIRECTORY_LEVEL && is_cpuid_PSE36())
                gfn += pse36_gfn_delta(pte);

And for that you can even use "> PG_LEVEL_4K" if you think it's nicer.

Paolo