RE: [PATCH][RESEND] Input: hyperv-keyboard: Add the support of hibernation

From: Dexuan Cui
Date: Wed Jan 15 2020 - 14:53:57 EST


> From: Sasha Levin <sashal@xxxxxxxxxx>
> Sent: Saturday, January 11, 2020 8:27 AM
> To: Dexuan Cui <decui@xxxxxxxxxxxxx>
> Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>; dmitry.torokhov@xxxxxxxxx;
> linux-hyperv@xxxxxxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Michael Kelley <mikelley@xxxxxxxxxxxxx>;
> Sasha Levin <Alexander.Levin@xxxxxxxxxxxxx>
> Subject: Re: [PATCH][RESEND] Input: hyperv-keyboard: Add the support of
> hibernation
>
> On Mon, Jan 06, 2020 at 02:40:44PM -0800, Dexuan Cui wrote:
> >Add suspend() and resume() functions so the Hyper-V virtual keyboard
> >can participate in VM hibernation.
> >
> >Note that the keyboard is a "wakeup" device that could abort an in-progress
> >hibernation if there is keyboard event. No attempt is made to suppress
> this
> >behavior. If desired, a sysadmin can disable the keyboard as a wakeup
> device
> >using standard mechanisms such as:
> >
> >echo disabled >
> /sys/bus/vmbus/drivers/hyperv_keyboard/XXX/power/wakeup
> >(where XXX is the device's GUID)
> >
> >Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> >Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> >---
> >
> >This is a RESEND of
> https://lkml.org/lkml/2019/11/24/115
> >
> >Please review.
> >
> >If it looks good, Sasha Levin, can you please pick it up via the
> >hyperv/linux.git tree, as you did last time for this driver?
>
> This will need an ack from the input driver maintainers, unless they
> want to give a blanket ack to this type of patches.
>
> --
> Thanks,
> Sasha

Hi Dmitry,
May I have your Acked-by for this patch?

Thanks,
-- Dexuan