Re: [PATCH v2] hv_netvsc: Fix memory leak when removing rndis device

From: David Miller
Date: Wed Jan 15 2020 - 16:38:47 EST


From: Mohammed Gamal <mgamal@xxxxxxxxxx>
Date: Tue, 14 Jan 2020 15:09:50 +0200

> kmemleak detects the following memory leak when hot removing
> a network device:
>
> unreferenced object 0xffff888083f63600 (size 256):
...
>
> rndis_filter_device_add() allocates an instance of struct rndis_device
> which never gets deallocated as rndis_filter_device_remove() sets
> net_device->extension which points to the rndis_device struct to NULL,
> leaving the rndis_device dangling.
>
> Since net_device->extension is eventually freed in free_netvsc_device(),
> we refrain from setting it to NULL inside rndis_filter_device_remove()
>
> Signed-off-by: Mohammed Gamal <mgamal@xxxxxxxxxx>

Applied, thanks.