Re: [PATCH] x86/cpu: clear X86_BUG_SPECTRE_V2 on Zhaoxin family 7 CPUs

From: Thomas Gleixner
Date: Wed Jan 15 2020 - 17:19:56 EST


Tony W Wang-oc <TonyWWang-oc@xxxxxxxxxxx> writes:

> These CPUs are not affected by spectre_v2, so clear spectre_v2 bug flag
> in their specific initialization code.
>
> if (cpu_has(c, X86_FEATURE_VMX))
> centaur_detect_vmx_virtcap(c);
> +
> + if (c->x86 == 7) {
> + setup_clear_cpu_cap(X86_BUG_SPECTRE_V2);
> + clear_bit(X86_BUG_SPECTRE_V2, (unsigned long *)cpu_caps_set);

No. Please use cpu_vuln_whitelist. It exists for exactly this
purpose. You just need to extend it with a NO_SPECTRE_V2 bit.

Thanks,

tglx