Re: [PATCH v4] riscv: make sure the cores stay looping in .Lsecondary_park
From: Anup Patel
Date: Wed Jan 15 2020 - 23:29:24 EST
On Thu, Jan 16, 2020 at 8:02 AM Paul Walmsley <paul.walmsley@xxxxxxxxxx> wrote:
>
> On Wed, 15 Jan 2020, Greentime Hu wrote:
>
> > The code in secondary_park is currently placed in the .init section. The
> > kernel reclaims and clears this code when it finishes booting. That
> > causes the cores parked in it to go to somewhere unpredictable, so we
> > move this function out of init to make sure the cores stay looping there.
> >
> > The instruction bgeu a0, t0, .Lsecondary_park may have "a relocation
> > truncated to fit" issue during linking time. It is because that sections
> > are too far to jump. Let's use tail to jump to the .Lsecondary_park.
> >
> > Signed-off-by: Greentime Hu <greentime.hu@xxxxxxxxxx>
>
> Thanks, queued for v5.5-rc. Anup's Reviewed-by: has been dropped since
> the patch changed significantly - Anup, if you are still happy with it,
> please reply with another Reviewed-by:. Thanks,
You can keep my Reviewed-by. I did not see any functional
changes in the patch so I am fine.
Thanks,
Anup