Re: [RFC PATCH 3/4] iommu: Preallocate iommu group when probing devices

[Lu Baolu]

Hi Joerg,

On 1/17/20 6:21 PM, Joerg Roedel wrote:
> On Wed, Jan 01, 2020 at 01:26:47PM +0800, Lu Baolu wrote:
> > This splits iommu group allocation from adding devices. This makes
> > it possible to determine the default domain type for each group as
> > all devices belonging to the group have been determined.
>
> I think its better to keep group allocation as it is and just defer
> default domain allocation after each device is in its group. But take
> care about the device hotplug path which might add new devices to groups
> which already have a default domain, or add new groups that might need a
> default domain too.
Thanks for the comment. It looks good to me. I will try to do it in the
next version.

Best regards,
baolu